Both are great ways to get exercise, and personally, I enjoy both. Swimming is great cardio and a full-body workout. On the other hand, lifting weights is great to increase strength and build muscle mass. Having a good regimen that includes both, and other exercises is great.